[FFmpeg-devel] [PATCH 1/5] avformat: add AVFMT_IMAGE2

[Michael Niedermayer]

On Fri, Mar 28, 2014 at 06:48:35PM +0100, wm4 wrote:
> On Fri, 28 Mar 2014 17:30:46 +0100
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavformat/avformat.h |    2 ++
> >  libavformat/utils.c    |    2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> > index f953d3d..1288897 100644
> > --- a/libavformat/avformat.h
> > +++ b/libavformat/avformat.h
> > @@ -435,6 +435,8 @@ typedef struct AVProbeData {
> >                                          */
> >  
> >  #define AVFMT_SEEK_TO_PTS   0x4000000 /**< Seeking is based on PTS */
> > +#define AVFMT_IMAGE2        0x8000000 /**< Demuxer intended to be used through image2 demuxer only */
> > +
> >  
> >  /**
> >   * @addtogroup lavf_encoding
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index a10c397..ac1a009 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -249,6 +249,8 @@ AVInputFormat *av_probe_input_format3(AVProbeData *pd, int is_opened,
> >      while ((fmt1 = av_iformat_next(fmt1))) {
> >          if (!is_opened == !(fmt1->flags & AVFMT_NOFILE))
> >              continue;
> > +        if (fmt1->flags & AVFMT_IMAGE2)
> > +            continue;
> >          score = 0;
> >          if (fmt1->read_probe) {
> >              score = fmt1->read_probe(&lpd);
> 
> I don't understand. Why this flag? I should be able to open a single

patchset where you can use the individual demuxers posted.
that means a 3rd codepath though now, that is direct use, use
though image2 and use though image2pipe


> image just fine. Especially without relying on that image2 thing, which
> is an API artifact and doesn't work with general probing.

image2 will probably grow probing support eventually
its definitl on my todo

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140328/ab14bda4/attachment.asc>