[FFmpeg-devel] [PATCH 1/4] lavu: add simple array implementation

[Michael Niedermayer]

On Sat, Mar 22, 2014 at 06:00:28PM +0100, Lukasz Marek wrote:
> On 21.03.2014 15:49, Nicolas George wrote:
> >Le primidi 1er germinal, an CCXXII, Lukasz Marek a écrit :
> >>intptr_t *tab = *(void**)tab_ptr;
> >>
> >>This line is copied from Nicolas implementation/original implementation.
> >
> >Yes, this line is currently present in the code. There is nothing that
> >prevents to fix it, I suppose just changing to "void *tab" would work, but
> >that seems orthogonal to the patches at hand.
> >
> >Regards,
> >
> 
> Patch attached. I hope I did it in correct way.

use of intptr_t is certainly not correct
void* and intptr_t might for example have different endianness or
size. intptr_t just has to be able to store a pointer,
a architecture with segment:offset pointers might have
48bit pointers but a 64bit intptr_t.
Above is of course hypothetical, and based on my understanding of
ISO C, i dont know if these occur on any relevant platforms and of
course i might be misinterpreting the spec


> BTW, this patch depends on Nicolas macro. Is it going to be merged
> in reasonable time?

applied the macro

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140322/d531895f/attachment.asc>