[FFmpeg-devel] [PATCH] doc/examples/muxing: make compatible with C++

[Michael Niedermayer]

On Wed, Mar 19, 2014 at 10:40:35AM +0100, Stefano Sabatini wrote:
> On date Wednesday 2014-03-19 11:45:08 +0530, anshul encoded:
> [...]
> > From dd883b6260e9622ab030dca3afc98e651c5cfd01 Mon Sep 17 00:00:00 2001
> > From: Anshul Maheshwari <er.anshul.maheshwari at gmail.com>
> > Date: Wed, 19 Mar 2014 11:42:06 +0530
> > Subject: [PATCH] added CPlusPlus examples
> > 
> > ---
> >  MAINTAINERS                            |   5 +
> >  Makefile                               |   7 +-
> >  doc/Makefile                           |  17 +-
> >  doc/examples_cpp/Makefile              |  44 ++
> >  doc/examples_cpp/README                |  23 +
> >  doc/examples_cpp/avcodec.cpp           | 659 ++++++++++++++++++++++++++++
> >  doc/examples_cpp/avio_reading.cpp      | 134 ++++++
> >  doc/examples_cpp/demuxing_decoding.cpp | 387 +++++++++++++++++
> >  doc/examples_cpp/filter_audio.cpp      | 365 ++++++++++++++++
> >  doc/examples_cpp/filtering_audio.cpp   | 283 +++++++++++++
> >  doc/examples_cpp/filtering_video.cpp   | 263 ++++++++++++
> >  doc/examples_cpp/metadata.cpp          |  58 +++
> >  doc/examples_cpp/muxing.cpp            | 614 +++++++++++++++++++++++++++
> >  doc/examples_cpp/remuxing.cpp          | 173 ++++++++
> >  doc/examples_cpp/resampling_audio.cpp  | 218 ++++++++++
> >  doc/examples_cpp/scaling_video.cpp     | 143 +++++++
> >  doc/examples_cpp/transcode_aac.cpp     | 754 +++++++++++++++++++++++++++++++++
> >  doc/examples_cpp/transcoding.cpp       | 602 ++++++++++++++++++++++++++
> >  18 files changed, 4746 insertions(+), 3 deletions(-)
> >  create mode 100644 doc/examples_cpp/Makefile
> >  create mode 100644 doc/examples_cpp/README
> >  create mode 100644 doc/examples_cpp/avcodec.cpp
> >  create mode 100644 doc/examples_cpp/avio_reading.cpp
> >  create mode 100644 doc/examples_cpp/demuxing_decoding.cpp
> >  create mode 100644 doc/examples_cpp/filter_audio.cpp
> >  create mode 100644 doc/examples_cpp/filtering_audio.cpp
> >  create mode 100644 doc/examples_cpp/filtering_video.cpp
> >  create mode 100644 doc/examples_cpp/metadata.cpp
> >  create mode 100644 doc/examples_cpp/muxing.cpp
> >  create mode 100644 doc/examples_cpp/remuxing.cpp
> >  create mode 100644 doc/examples_cpp/resampling_audio.cpp
> >  create mode 100644 doc/examples_cpp/scaling_video.cpp
> >  create mode 100644 doc/examples_cpp/transcode_aac.cpp
> >  create mode 100644 doc/examples_cpp/transcoding.cpp
> 
> As documentation maintainer I'm against this, since it's going to be a
> hell to maintain, and I don't want to duplicate code changes/tests and
> have to keep C/C++ code in synch.

Understood, you dont have to touch or maintain these examples though
this would be the "duty" of their maintainer

+Examples
+========
+
+C++ Examples                           Anshul MAheshwari
+

And in case they become unmaintained, removing them, to prevent
outdated examples to be there, is easy


> 
> What I suggest instead: we extend documentation on the wiki regarding
> FFmpeg support with C++, so that the user knows exactly what
> conversions are required when porting the code to C++.

Thats possible but its inconvenient compared to having examples
where these changes have already been done.

so to summarize we have

A. add ~6 lines of code to each example to make it C++ compatible
B. add seperate C++ examples
C. add patches that get applied by makefile to create c++ examples
D. add a description to the wiki/faq/whatever on how to make the
   examples C++ compatible

Iam happy with any solution if theres a consensus, that is if the
people in this thread, including Anshul agree.

In absence of a consensus, anyone can volunteer to maintain C++
examples and its then his/her decission on how to maintain them,
that is in git as seperate files or on the wiki or as patches.

I think its better if a consensus is found though, but i dont know
if thats possible, peoples oppinion seem far appart

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140319/85a8a391/attachment.asc>