[FFmpeg-devel] [PATCH]Fix TARGET_SAMPLES and TARGET_PATH for some fate tests

Michael Niedermayer michaelni at gmx.at
Sun Mar 16 17:23:17 CET 2014


On Sun, Mar 16, 2014 at 05:03:59PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes some fate tests with target-exec on remote hardware.
> 
> Please comment, Carl Eugen

>  Makefile              |    2 +-
>  fate/ffmpeg.mak       |   10 +++++-----
>  fate/filter-audio.mak |    2 +-
>  fate/filter-video.mak |    6 +++---
>  fate/gif.mak          |    2 +-
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 3fc61f530f8c5e0d995a4dcf0f1fdaafc0864fb5  patchtargetfate2.diff
> diff --git a/tests/Makefile b/tests/Makefile
> index ff5fc2b..7606a14 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -177,7 +177,7 @@ fate:: $(FATE)
>  
>  $(FATE) $(FATE_TESTS-no): $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
>  	@echo "TEST    $(@:fate-%=%)"
> -	$(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(SAMPLES)" "$(TARGET_EXEC)" "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)' '$(THREADS)' '$(THREAD_TYPE)' '$(CPUFLAGS)' '$(CMP_SHIFT)' '$(CMP_TARGET)' '$(SIZE_TOLERANCE)' '$(CMP_UNIT)' '$(GEN)'
> +	$(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(TARGET_SAMPLES)" "$(TARGET_EXEC)" "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)' '$(THREADS)' '$(THREAD_TYPE)' '$(CPUFLAGS)' '$(CMP_SHIFT)' '$(CMP_TARGET)' '$(SIZE_TOLERANCE)' '$(CMP_UNIT)' '$(GEN)'

the samples variable this gets assigned too should also be
renamed to ensure its content matches

patch should be ok oterwise

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140316/ade8f341/attachment.asc>


More information about the ffmpeg-devel mailing list