[FFmpeg-devel] [FFmpeg-cvslog] lavf: more correct printf format specifiers

[James Almer]

On 11/03/14 5:43 PM, Clément Bœsch wrote:
> On Tue, Mar 11, 2014 at 09:12:06PM +0100, Diego Biurrun wrote:
>> diff --git a/libavformat/wtv.c b/libavformat/wtv.c
>> index 0c24fd7..c85f374 100644
>> --- a/libavformat/wtv.c
>> +++ b/libavformat/wtv.c
>> @@ -25,6 +25,8 @@
>>   * @author Peter Ross <pross at xvid.org>
>>   */
>>  
>> +#include <inttypes.h>
>> +
>>  #include "libavutil/channel_layout.h"
>>  #include "libavutil/intreadwrite.h"
>>  #include "libavutil/intfloat.h"
>> @@ -37,7 +39,7 @@
>>  
>>  /* Macros for formating GUIDs */
>>  #define PRI_PRETTY_GUID \
>> -    "%08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x"
>> +    "%08"PRIx32"-%04"PRIx16"-%04"PRIx16"-%02x%02x%02x%02x%02x%02x%02x%02x"
>>  #define ARG_PRETTY_GUID(g) \
>>      AV_RL32(g),AV_RL16(g+4),AV_RL16(g+6),g[8],g[9],g[10],g[11],g[12],g[13],g[14],g[15]
>>  #define LEN_PRETTY_GUID 34
>> @@ -501,7 +503,7 @@ static void get_tag(AVFormatContext *s, AVIOContext *pb, const char *key, int ty
>>          return;
>>  
>>      if (type == 0 && length == 4) {
> 
>> -        snprintf(buf, buf_size, "%"PRIi32, avio_rl32(pb));
>> +        snprintf(buf, buf_size, "%u", avio_rl32(pb));
> 
> ??

https://lists.libav.org/pipermail/libav-devel/2014-March/057164.html

Not sure how true is that (afaik unsigned int == uin32_t on every platform, but
i may be wrong), and i didn't care enough to argue.