[FFmpeg-devel] [PATCH] 5 patches from the Debian packaging

[Andreas Cadhalpun]

On 06.03.2014 20:54, Reimar Döffinger wrote:
> On Thu, Mar 06, 2014 at 08:03:20PM +0100, Andreas Cadhalpun wrote:
>>   * The fourth patch is probably the most important one, as it fixes the
>> tests (make check), when building shared libraries, by exporting
>> LD_LIBRARY_PATH in the Makefile.
>
> I don't have a better suggestion, but "export" will not work in all
> shells I believe, and LD_LIBRARY_PATH will not work on e.g. Windows
> (where you would have to set PATH instead), that makes it feel rather
> messy.
> I kind of think it might be better to leave setting up the environment
> to the user.

It works with sh and bash, so one could use:
([ $(SHELL) = /bin/sh ] || [ $(SHELL) = /bin/bash ]) && export ...

Similar lines could be added for other shells/Windows, but I don't know 
what commands are necessary for these.

>>   * The fifth patch removes uses of the deprecated texi2html in favor of
>> makeinfo. This is done, because texi2html is expected not to be in the next
>> Debian release. I'm not sure, how far this deprecation has gone outside of
>> Debian, or if everyone can use makeinfo. So maybe this patch should not be
>> applied for the 2.2 release, but since texi2html is not developed anymore,
>> it makes sense to switch to makeinfo sooner or later.
>
> Have you looked at if/how the output differs between these tools?
> Both visually in the browser and as far as the generated HTML is
> concerned?

The output is a bit differently formatted, but the content is the same. 
See for example the attachments for libavfilter.html.

> Also, does this possibly require a newer version of makeinfo than
> some people might have (I mean there must be a reason we don't use it?)
> Otherwise depending on one fewer tool is a good thing IMHO.

It works with texinfo 5.2.0 (in Debian testing), but it doesn't work 
with texinfo 4.13a (in Debian stable). So I guess it works with any 
version above 5 (approximately one year old). Probably not everyone has 
new enough versions.

Best regards,
Andreas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: libavfilter_html.diff
Type: text/x-diff
Size: 4863 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140307/04a739d7/attachment.bin>