[FFmpeg-devel] [PATCH] lavf/concatdec: allow to match streams by id.

[Michael Niedermayer]

On Sun, Mar 02, 2014 at 03:34:20PM +0100, Nicolas George wrote:
> Le duodi 12 ventôse, an CCXXII, Michael Niedermayer a écrit :
> > Do i understand correctly that in such case the user has to
> > specify the stream maping one by one ?
> 
> More precisely a list of all the streams wanted in the output file with
> their id.
> 
> > I think it would be better if (additionally) the code tried to match
> > streams automatically based on codec id, resolution, language, channel
> > layout
> > (possibly program name if its TS)
> 
> That is something I intend to implement at some point (unless someone does
> it before me), but I believe this is a different use case, and both are
> needed. See my recent patch "dvd2concat" for the use case of this feature.
> 
> Maybe a more explicit keyword than "id" would be better for this case:
> possibly "exact_id".
> 
> > this leaves a stale pointer in cat->cur_file->stream_map
> 
> This is not a problem. Even if the caller ignores the error (it should not),
> it will just return packets for a stream with unknown characteristics, just
> like random binary data streams.

there are 2 returns in there
the first happens when the realloc failed and the original buffer is
still allocated
the second happens later when the original has been freed and the
new buffer has not been returned to the user


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140302/8ebe5eff/attachment.asc>