[FFmpeg-devel] [PATCH 4/8] lavu/opt: extend AVOptionRange by second value

Nicolas George george at nsup.org
Sun Mar 2 15:54:11 CET 2014


Le decadi 10 ventôse, an CCXXII, Lukasz Marek a écrit :
> I promise it is the last one. No more from me for this thread unless
> you decide what you want :P

I would suggest to drop this part for now and concentrate on landing the
device probe API itself. The device probing does not actually need the
extended range structure, these enhancements can be added later.

So my advice is to finish the probing API, and see how it works to see how
the range structure can be improved.

> +    double multiple_of;                        ///< Valid values have to be multiple of multiple_of. Ignore if multiple_of is 0.

Same thing here: you do not have to feel obligated to implement every
suggestion that appears in the discussion. Even when they are a good idea,
if they are not necessary for the work you can leave them for a separate
patch series.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140302/578c9f87/attachment.asc>


More information about the ffmpeg-devel mailing list