[FFmpeg-devel] [PATCH] EBU Tech 3285 - Supplement 3 - Peak Envelope Chunk encoder

[Carl Eugen Hoyos]

Georg Lippitsch <georg.lippitsch <at> gmx.at> writes:

> -    /* format header */
> -    fmt = ff_start_tag(pb, "fmt ");
> -    if (ff_put_wav_header(pb, s->streams[0]->codec, 0) < 0) {
> -        const AVCodecDescriptor *desc = 
> avcodec_descriptor_get(s->streams[0]->codec->codec_id);
> -        av_log(s, AV_LOG_ERROR, "%s codec not supported in WAVE format\n",
> -               desc ? desc->name : "unknown");
> -        return AVERROR(ENOSYS);

> -    ff_end_tag(pb, fmt);

Please do not re-indent these lines.

Some developers disagree but this is still what our 
documentation says and it definitely makes reviewing 
(both now and in the future) easier.

Imo, this is also true for one chunk below but feel 
free to ignore if you disagree.

Thank you, Carl Eugen