[FFmpeg-devel] [PATCH] MPEG-TS/-PS : better probing for duration and start-time for all streams in a container

[Michael Niedermayer]

On Thu, Jun 19, 2014 at 05:26:31PM +0000, Gaullier Nicolas wrote:
> >> Finally, I decided to split the patch to keep only the duration update.
> >> For the record, it is to replace ff_read_packet that returns packet 
> >> with "uncomputed" zero duration, and a reset for last_dts to disable a non relevant warning due to the retry process.
> >> (FATE pass ok)
> >
> >ive the suspicion that replacing this call is not trivial
> >
> >either way, please test your code against a wider range of samples if you happen to have some random ones laying around that you can easily test or maybe download some from >http://samples.ffmpeg.org/
> >
> >for example
> >https://trac.ffmpeg.org/raw-attachment/ticket/3658/tv.800000.100_cut.ts
> >
> >ffmpeg -i tv.800000.100_cut.ts -codec copy -f framecrc -
> >
> >will fail after the patch about 1/3 into the file
> 
> It seems it is more secure to simply duplicate the computing routine from compute_pkt_fields to estimate_timings_from_pts.
> If you think it is worth creating a new function to avoid doubling source code, please restructure it as you want.
> 
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 517d919..b25576e 100644

patch applied

thanks


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140619/4a08ea14/attachment.asc>