[FFmpeg-devel] [PATCH] libx265: Update bitrate in avcontext in case it was overriden by x265 specific options

[Nicolas Morey-Chaisemartin]

Sorry for the style. First time looking into ffmpeg code :)

I guess it could be unconditional too but it didn't seem to make much sense to copy the target bitrate if we use CQP or CRF modes.
The issue behind this is when a user passes something like -x265-params bitrate=10000 on the command line, ffmpeg summary still outputs something like this:

Output #0, hevc, to 'output.hevc':
   Metadata:
     encoder         : Lavf55.33.100
     Stream #0:0: Video: hevc (libx265), yuv420p, 1280x720 [SAR 1:1 DAR 16:9], q=2-31, *200 kb/s*, 90k tbn, 50 tbc

Although the right target bitrate is used, the message is a bit unsettling for end users :)

On another subject, is it the wanted behavior to silently ignore x265-params string if av_dict_parse_string fails?
x264 wrapper does the same but it's a real hassle to figure out why option keep being ignored !

Nicolas

On 06/13/2014 03:07 PM, Derek Buitenhuis wrote:
> On 6/13/2014 9:49 AM, Nicolas Morey-Chaisemartin wrote:
>> ---
>>    libavcodec/libx265.c | 4 +++-
>>    1 file changed, 3 insertions(+), 1 deletion(-)
> Random whitespace changes and inconsistent style aside: Why?
>
> I see the libx264.c wrapper does this unconditionally, but I cannot find
> a reason why. The earliest appearance of it is in this barely-English, and
> completely unrelated commit from Baptiste: 0140d3f0921e5cbb6ea8706acb0307f7ff57a133.
> What the fuck?
>
> I am happy to add this to the libx265 wrapper if-and-only-if someone can
> tell me why it must be done, since Baptiste's commit is so shitty^Wunhelpful.
>
> Cheers,
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel