[FFmpeg-devel] [PATCH v2] swscale: Allow the max filter size to be set at compile time

[Clément Bœsch]

On Wed, Jun 11, 2014 at 06:20:32PM +0100, Derek Buitenhuis wrote:
> On 6/11/2014 6:18 PM, Clément Bœsch wrote:
> >>      target_exec
> >> @@ -2646,6 +2648,8 @@ enable safe_bitstream_reader
> >>  enable static
> >>  enable swscale_alpha
> >>  
> >> +sws_max_filter_size_default=256
> >> +
> > 
> > You should probably move that a bit above, around "default parameters"
> > (~L2590)
> 
> This is still in the default settings section.
> 

Yeah well it was after the "enable" list so it didn't look it was
belonging here. Not important nit.

> >> +if test -n "$sws_max_filter_size"; then
> >> +    echo "#define SWS_MAX_FILTER_SIZE $sws_max_filter_size" >>$TMPH
> >> +else
> >> +    echo "#define SWS_MAX_FILTER_SIZE $sws_max_filter_size_default" >>$TMPH
> >> +fi
> > 
> > Is the indirection necessary if you "sws_max_filter_size=256" and let the
> > configure update it?
> 
> I wasn't sure how our configure script worked, i.e. if that was even possible.
> 
> Is it?

Probably, look for ^set_default around line 2980

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140611/fa23801d/attachment.asc>