[FFmpeg-devel] [PATCH 1/2] avutil/libm: Replace macro based fminf() by function

[Clément Bœsch]

On Fri, Jun 06, 2014 at 04:42:15PM +0200, Michael Niedermayer wrote:
> This avoids issues when the FFMIN parameter evaluation has sideeffects

let's add a space between the 2 'ee'...

> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavutil/libm.h |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/libm.h b/libavutil/libm.h
> index eacb3cc..cb79728 100644
> --- a/libavutil/libm.h
> +++ b/libavutil/libm.h
> @@ -84,7 +84,10 @@ static av_always_inline float cbrtf(float x)
>  
>  #if !HAVE_FMINF
>  #undef fminf
> -#define fminf(x, y) (FFMIN(x,y))
> +static av_always_inline av_const float fminf(float x, float y)
> +{
> +    return FFMIN(x,y);

... and after the comma here

And yeah patch LGTM, thx

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140606/cb8e6baf/attachment.asc>