[FFmpeg-devel] [PATCH] avfilter/bufferqueue: Increase buffer queue size

Michael Niedermayer michaelni at gmx.at
Wed Jun 4 19:01:01 CEST 2014


On Wed, Jun 04, 2014 at 05:16:32PM +0200, Tobias Rapp wrote:
> Nicolas George wrote:
> > [...]
> >
> > In the meantime, I am ok with rising the value to 64, it is quite reasonable
> > and fixes a well identified and common case. The commit message should
> > explain it. Something like that: "Files produced by [that product] have the
> > first second of audio not interleaved. With common settings, that makes more
> > than 32 frames but less than 64."
> > 
> > And for people who need a still larger value, for now I say: double-check
> > your filter graph if you do not want to risk an oom crash, and then insert
> > fifo or afifo where the overflow occurs.
> 
> Thanks for the informative comments, Nicolas.
> 
> Have attached a patch file with updated commit message.
> 
> Regards,
> Tobias

>  bufferqueue.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> e4787181141551ad3708c3d5a8cb2aed1baee58e  0001-avfilter-bufferqueue-Increase-buffer-queue-size.patch
> From d13c70a65c4c0a1079856eda56f8088915548f08 Mon Sep 17 00:00:00 2001
> From: Tobias Rapp <t.rapp at noa-audio.com>
> Date: Tue, 3 Jun 2014 08:43:24 +0200
> Subject: [PATCH] avfilter/bufferqueue: Increase buffer queue size
> 
> Avoid buffer overruns when processing some MOV files with the amerge
> filter. Files produced by Adobe Premiere Pro CC have up to one second of audio
> not interleaved. With common settings (<= 48kHz) that makes up to 47 frames so
> a queue length of 64 makes sense.
> 
> Fixes ticket #3510.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140604/7e3c22dd/attachment.asc>


More information about the ffmpeg-devel mailing list