[FFmpeg-devel] [PATCH 3/5] [FATESERVER] Add support for querying a specific compiler, OS, and/or architecture

[Derek Buitenhuis]

On 6/1/2014 12:45 AM, Timothy Gu wrote:
> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> ---
>  FATE.pm   |  2 +-
>  index.cgi | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  2 files changed, 67 insertions(+), 6 deletions(-)

IMO querying a specific compiler is pretty useless, given what FATE setups we have,
and the small number of overlapping version strings.

> +# Format for /?query= : /?query=type:value//type:value// (URI encoded).
> +# Trailing // does not matter (i.e. may be added).
> +# @queries contains an array of 'type:value' strings.
> +# Every member of @queries can be further parsed with another simple
> +# split(/:/, $this_query, 2);
> +my @queries = split(/\/\//, uri_unescape param 'query') if (param 'query');
> +
> +(my $uri = $ENV{REQUEST_URI}) =~ s/\?.*//;

Out of scope likely, but, why on earth are we using split and regex to
parse URIs instead of a real URI parser?

- Derek