[FFmpeg-devel] [PATCH]Check if free atoms in mov are actually moov atoms

[tim nicholson]

On 31/05/14 09:29, Carl Eugen Hoyos wrote:
> On Thursday 06 March 2014 01:29:13 pm Carl Eugen Hoyos wrote:
>> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
>>> Attached patch fixes ticket #1551, this is how vlc decodes
>>> the sample.
>>
>> As-is, this is probably not such a good idea, the vlc code
>> only uses the "bad" atom if no moov atom was found:

It is not uncommon for a valid mov file to have several "free" atoms
that contain valid "moov" information from before an alteration.

In the circumstances where some operation gets as far as changing the
"current" moov atom to "free", but then fails to create a valid new moov
atom, the best choice of which "old" version to use, is probably the
last (i.e the one nearest the end of the file) not the first one that
matches the type.


>> http://git.videolan.org/?p=vlc.git;a=commitdiff;h=b5a213db
> 
> New patch attached.
> 
> Please comment, Carl Eugen
> 
> 
> [..]

-- 
Tim