[FFmpeg-devel] [PATCH] ffprobe: print some basic information about avframe side data

[Michael Niedermayer]

On Tue, Jul 01, 2014 at 07:20:13PM +0200, Clément Bœsch wrote:
> On Tue, Jul 01, 2014 at 05:50:11PM +0200, Michael Niedermayer wrote:
> > On Mon, Jun 30, 2014 at 06:37:45PM +0200, Clément Bœsch wrote:
> > > On Mon, Jun 30, 2014 at 04:16:17AM +0200, Michael Niedermayer wrote:
> > > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > > ---
> > > >  ffprobe.c |    6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > > 
> > > > diff --git a/ffprobe.c b/ffprobe.c
> > > > index 1329466..e96f51f 100644
> > > > --- a/ffprobe.c
> > > > +++ b/ffprobe.c
> > > > @@ -1722,6 +1722,7 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
> > > >  {
> > > >      AVBPrint pbuf;
> > > >      const char *s;
> > > > +    int i;
> > > >  
> > > >      av_bprint_init(&pbuf, 1, AV_BPRINT_SIZE_UNLIMITED);
> > > >  
> > > > @@ -1765,6 +1766,11 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
> > > >          print_int("interlaced_frame",       frame->interlaced_frame);
> > > >          print_int("top_field_first",        frame->top_field_first);
> > > >          print_int("repeat_pict",            frame->repeat_pict);
> > > > +        for (i = 0; i < frame->nb_side_data; i++) {
> > > > +            AVFrameSideData *sd = frame->side_data[i];
> > > > +            print_int("side_data_type", sd->type);
> > > > +            print_int("side_data_size", sd->size);
> > > > +        }
> > > 
> > > I suppose there are a few writers where having multiple time the same key
> > > will cause problems...
> > 
> > what do you suggest instead ?
> > 
> 
> Probably like we do with streams for instance. You'll have to create a new
> "side data" section I suppose.

done and resubmitted

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140730/044773dc/attachment.asc>