[FFmpeg-devel] [PATCH 2/4] lavfi/buffersrc: add add av_buffersrc_close().

[wm4]

On Wed, 30 Jul 2014 00:13:38 +0200
Nicolas George <george at nsup.org> wrote:

> Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> > I asked for the reason of the API change. What's the purpose of the API
> > change, if the "deprecated" method is supported forever anyway?
> 
> What's the purpose of deprecating gets() in favour of fgets() if the
> deprecated function is supported forever anyway?

gets() has fundamental, unfixable security issues. The libavfilter API
for EOF is ok, and not much different from e.g. libavcodec codec
flushing. So if you're not actually fixing anything (in the API, not
filter implementations), it's more important not to change the API for
no reason.

> The reason is called "compatibility": old programs will still work, with the
> same problems as before. Fortunately, unless gets(), adding a NULL frame
> does not open a security risk, it just gives a slightly wrong result.

What wrong result? Isn't it an implementation problem? You could fix it
without changing the API.