[FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

[Michael Niedermayer]

On Tue, Jul 29, 2014 at 01:29:16AM +0200, Nicolas George wrote:
> Le decadi 10 thermidor, an CCXXII, Michael Niedermayer a écrit :
> > Breaks ABI, AVFrame size is depending on libavutil and may be non
> > constant for a libavfilter build
> 
> That was intentional (that makes the code simpler with less error checks):
> the frame is only allocated and used internally, so this is safe.
> 
> Apart from the "format" field, which is public and part of the ABI, you can
> consider this is a "FFLavfiFrame2" structure that just happens to be
> identical to AVFrame at the time lavfi was built but will not follow its
> evolution.
> 
> I am ok with using a more classic approach if people insist, though.

I dont insist, though i think properly allocating is safer against
someone mistakely using that frame with some function from libavutil
in the future.
If you leave it, please document that this direct use of an AVFrame
is safe in this case

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140729/ad4beb91/attachment.asc>