[FFmpeg-devel] [PATCH 1/3] avcodec: add avdsp

Ronald S. Bultje rsbultje at gmail.com
Sat Jul 26 15:58:16 CEST 2014


Hi,


On Sat, Jul 26, 2014 at 9:34 AM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> This provides a public sustainable API/ABI for DSP functions.
> Only externally used dsp functions are included.
> The structure is extensible without ABI issues compared to the
> existing dsp contexts.


Please don't add new shithole-for-everything structs and interfaces, we
already have enough of these. Just call it "avsimpleidctcontext" or
"avsimplefdctcontext" or something, and put just idct or just fdct in it. I
don't mind the concept of externally visible structs at all, but this seems
designed as dsputil-with-an-av-prefix and that's scary.

Please don't reintroduce dsputil with most issues still there.

Ronald


More information about the ffmpeg-devel mailing list