[FFmpeg-devel] [PATCH] avcodec: increase FF_INPUT_BUFFER_PADDING_SIZE to 32

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Jul 20 22:43:30 CEST 2014


On 12.06.2014 08:42, Christophe Gisquet wrote:
> Hi,
>
> 2014-06-11 21:29 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
>> -#define FF_INPUT_BUFFER_PADDING_SIZE 16
>> +#define FF_INPUT_BUFFER_PADDING_SIZE 32
>
> So, following the discussion on how API users may be affected by this
> change, does that need an API bump?

One effect of this change is that now mplayer2 fails to build, because 
it uses this check:
#if MP_INPUT_BUFFER_PADDING_SIZE < FF_INPUT_BUFFER_PADDING_SIZE
#error MP_INPUT_BUFFER_PADDING_SIZE is too small!
#endif

MP_INPUT_BUFFER_PADDING_SIZE is defined as 16. Increasing that to 32 
allows building mplayer2 again.

So I think an API bump wouldn't have been a bad idea.

Best regards,
Andreas


More information about the ffmpeg-devel mailing list