[FFmpeg-devel] [PATCH] Revert "lavc/utils: Do not require dimensions for PNG."

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Jul 14 16:25:53 CEST 2014


On 7/14/2014 8:15 AM, Reimar Döffinger wrote:
> There is also the issue about how much sense the check makes: while I decided to do it (slightly) more properly, a "fix" would be to just set width/height to 320x240 no matter what you actually encode in the end.

This is a bad idea. API users don't necessarily see av_log stuff, and just using
a random resolution will only lead to confusion/bad things. Failing loudly
due to API misuse is always preferred over try to guess or fix what they wanted
to do.

- Derek


More information about the ffmpeg-devel mailing list