[FFmpeg-devel] [PATCH] avutil & avdevice: remove av_bprint_fd_contents()

Michael Niedermayer michaelni at gmx.at
Mon Jul 14 02:27:37 CEST 2014


On Sun, Jul 13, 2014 at 04:01:05PM +0200, Michael Niedermayer wrote:
> MSVC does not allow passing file pointers between libs
> This API can thus not work with MSVC and as it was very recently added
> and its it was in no release its removial should not cause any problems
> 
> Found-by: Hendrik Leppkes <h.leppkes at gmail.com>
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavdevice/lavfi.c |   39 ++++++++++++++++-----------------------
>  libavutil/bprint.c  |   24 ------------------------
>  libavutil/bprint.h  |    7 -------
>  3 files changed, 16 insertions(+), 54 deletions(-)

an alternative suggestion or after this patch
would be to switch to passing a filename string instead of a int fd
and treat "" as stdin

andrey, whats your oppinion about that ?
also if you like the suggestion, do you have time to make that change ?

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140714/16d5322a/attachment.asc>


More information about the ffmpeg-devel mailing list