[FFmpeg-devel] [PATCH] Revert "lavc/utils: Do not require dimensions for PNG."

[Derek Buitenhuis]

On 7/13/2014 9:17 PM, Reimar Döffinger wrote:
> Well, IMHO if this is a requirement that was added, I would say
> it was an API change, and MPlayer might just be the first where
> the API change was detected.

Indeed there should have been a version bump in 419ade4b6193c6eb626cda01b21e7091f42b2cc2.

> I suspect it is in part there to work around a fairly specific issue:
> For a screenshot filter the resolution might change any time,
> and requiring a full reinitialization is a bit of a pain/performance
> issue, particularly when we have no real reason to require it.

I find that the penalty for reinit is probably really low. Seems like
"optimization".

> But yes, unless someone feels like coming up with a implementation
> for such a "feature" removing it probably makes most sense (though I
> still prefer such things to be done at version bumps).

Agreed.

> I'll try to double-check and fix any issues there are (btw, if such hack
> are added in the future it would be good to add a big ugly message to
> make sure anyone affected actually fixes the issues instead of
> forgetting about it).

Cool!

- Derek