[FFmpeg-devel] [PATCH] AVFormat: LRC demuxer and muxer

[Michael Niedermayer]

On Fri, Jul 11, 2014 at 07:16:04PM +0800, Star Brilliant wrote:
> On 2014-07-09 23:09, Derek Buitenhuis wrote:
> >>>>+        *start = -(mm*60000LL + ss*1000LL + cs*10LL); // just in case negative pts
> >
> >That said, there is still a bug. %d will read negative integers already, you
> >do not need to check for '-'.
> 
> I forgot to mention it in the previous mail.
> It is not a bug. Although %d reads negative integers, the seconds
> and centiseconds are not correctly read.
> I have tried various ways to read both mm:ss.cs -mm:ss.cs
> combination, and the one I am using now really works.
> 

> I have also tested the demuxer with some samples that I have. Do you
> think it is necessary to add them into the FATE dataset?

fate tests would be a very good idea
if a sample is needed for such tests, i can upload it, just tell me
what i need to put in which directory

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140712/8c54cc07/attachment.asc>