[FFmpeg-devel] [PATCH 2/2] lavf: Add WebM DASH Manifest Muxer

[Timothy Gu]

On Jul 7, 2014 12:44 PM, "Vignesh Venkatasubramanian" <vigneshv at google.com>
wrote:
>
> On Mon, Jul 7, 2014 at 12:39 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
> > On Jul 7, 2014 9:38 AM, "Vignesh Venkatasubramanian" <
vigneshv at google.com>
> > wrote:
> >>
> >> On Mon, Jun 30, 2014 at 4:26 PM, Timothy Gu <timothygu99 at gmail.com>
wrote:
> >> > On Mon, Jun 30, 2014 at 3:44 PM, Vignesh Venkatasubramanian
> >> > <vigneshv at google.com> wrote:
> >> >
> >
> >> >> +#define OFFSET(x) offsetof(WebMDashMuxContext, x)
> >> >> +static const AVOption options[] = {
> >> >> +    { "adaptation_sets", "Adaptation sets. Syntax
id=0,streams=0,1,2
> > id=1 streams=3,4 and so on",
> >> >> OFFSET(adaptation_sets), AV_OPT_TYPE_STRING, { 0 }, 0, 0,
> > AV_OPT_FLAG_ENCODING_PARAM },
> >> >
> >> > I don't get the help message. Is it supposed to be:
> >> > "id=0,streams=0,1,2 id=1,streams=3,4"
> >> > or "id=0 streams=0,1,2 id=1 streams=3,4"?
> >> >
> >> > Also this needs an doc/muxers.texi update, preferably with some
> >> > real-world examples.
> >> >
> >>
> >> the purpose of this parameter is to combine streams into adaptation
> >> sets with a unique id. so it would go like this: "id=1,streams=0,1,2
> >> id=2,streams=3,4". This means that: streams 0, 1 and 2 belong to the
> >> same adaptation set with the unique identifier 1; streams 3 and 4
> >> belong to the same adaptation set with unique identifier 2. it is sort
> >> of a parameter within a parameter. please let me know if it makes
> >> sense now.
> >
> > That's what I thought, but you typed a space instead of a comma after
id=1
> > in the help message.
>
> yes, i intended to use a comma so that each adaptation set's
> parameters can be separated by a space. "id" and "streams" are two
> parameters for an adaptation set and i have kept them together
> separated by comma. if that does not make sense, then i can use space
> to separate them and infer it as: any "streams" followed by an "id"
> will belong to that "id".

Still wrong. You wrote:
Syntax id=0,streams=0,1,2 id=1 streams=3,4 and so on

Should be:
Syntax id=0,streams=0,1,2 id=1,streams=3,4 and so on

Timothy