[FFmpeg-devel] [PATCH] doc/ffprobe.xsd fixes for order and missing elements/attributes

[Dave Rice]

Hi,

On Jul 1, 2014, at 7:44 PM, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Monday 2014-06-30 17:30:02 -0400, Dave Rice encoded:
>> This patch allows the ffprobe schema to validate properly.
> 
>> I switched the order to programs and streams and moved program and
>> library versions to the beginning. to correspond to the output of
>> ffprobe.
> 
> Is that relevant for validation purposes (I'm quite sure I tested it
> with xmllint)?

Yes, the element order counts. You can test the current validation issue with:
ffprobe -f lavfi mandelbrot -show_versions -show_streams -of xml=q=1:x=1 -noprivate > test.xml
xmllint --noout --schema ffprobe.xsd test.xml

which gives an error on line 16 since <streams> occurs after <library_versions>

test.xml:3: element program_version: Schemas validity error : Element 'program_version', attribute 'compiler_ident': The attribute 'compiler_ident' is not allowed.
test.xml:3: element program_version: Schemas validity error : Element 'program_version': The attribute 'compiler_type' is required but missing.
test.xml:3: element program_version: Schemas validity error : Element 'program_version': The attribute 'compiler_version' is required but missing.
test.xml:16: element streams: Schemas validity error : Element 'streams': This element is not expected.
test.xml fails to validate

>> Also the tag element was missing from frameType.
>> Also it appears that compiler_ident has replaced compiler_type and compiler_version but the xsd was not updated.
> 
> Yeah this happened in 85044358.

[...]

> Please create a patch with git-format, complete with author
> info. Patch itself looks good.

Attached,
Dave Rice