[FFmpeg-devel] [PATCH 2/2] lavf: Add WebM DASH Manifest Muxer

[Vignesh Venkatasubramanian]

On Mon, Jun 30, 2014 at 4:10 PM, Clément Bœsch <u at pkh.me> wrote:
> On Mon, Jun 30, 2014 at 04:06:03PM -0700, Vignesh Venkatasubramanian wrote:
>> On Mon, Jun 30, 2014 at 4:00 PM, Clément Bœsch <u at pkh.me> wrote:
>> > On Mon, Jun 30, 2014 at 03:44:37PM -0700, Vignesh Venkatasubramanian wrote:
>> > [...]
>> >> +static void write_string(AVFormatContext *s, const char *str, int should_free)
>> >> +{
>> >> +    avio_write(s->pb, str, strlen(str));
>> >> +    if (should_free)
>> >> +        av_free((char*)str);
>> >> +}
>> >
>> > Why not use avio_printf() instead of some weird jungling with
>> > av_asprintf() and should_free?
>> >
>>
>> no reason. just didn't know about avio_printf. will change.
>>
>
> Just make sure a 4k buf is enough for your use cases though. If not, you
> could update avio_printf() to make it use av_asprintf()
>

i think 4k buffer should be fine. i don't see a single call being
longer than that.

> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>



-- 
Vignesh