[FFmpeg-devel] [PATCH][RFC] Add example seeking_while_remuxing.c

Stefano Sabatini stefasab at gmail.com
Fri Jan 31 00:57:25 CET 2014


On date Tuesday 2014-01-28 11:37:09 +0200, Andrey Utkin encoded:
> 2014-01-28 Stefano Sabatini <stefasab at gmail.com>:
> > This seems to contain much code from remuxing.c. What if you apply
> > your changes on top of that? Having many files to maintain means more
> > work for maintainers.
> 

> Adding new seeking code directly to remuxing.c is possible, although i
> am not sure whether it would be good to read such example, i.e.
> wouldn't they get too complicated. I think remuxing.c is great for its
> simplicity now, it's good template to start different app sketches
> now. So i am ok to unify my sketch with remuxing.c, but i'd vote for
> saving remuxing.c as it is now.

It depends how much *more* complicate it would be? As a rule of thumb,
if it is just a few lines (say less than 100) and the new logic code
can be easily separated than that's better than maintaining two
separate files.

 
> However now i'm working on filtering_video.c example to add encoding
> and muxing demonstration here. Also i think i'll add there remuxing or

> reencoding input audio. Would it be good to apply it to original
> filtering_video.c, or would it better become separate transcode.c?

transcode.c with filtering would be nice.

> Also what about that large comment block? Is it fully correct? What
> about the used approach?

I didn't read it yet...
-- 
FFmpeg = Fiendish and Friendly Mega Peaceful Epic Gymnast


More information about the ffmpeg-devel mailing list