[FFmpeg-devel] [PATCH 0/8] User controllable padding v3

Michael Niedermayer michaelni at gmx.at
Fri Jan 24 23:17:26 CET 2014


On Fri, Jan 24, 2014 at 07:50:47PM +0100, James Darnley wrote:
> I'm not sure if anyone saw the last time I posted these patches so I
> will repeat the changelog I sent last time and reword it for clarity.
> 
> I followed some of the suggestions from first time I posted this.  I
> made the maximum value INT_MAX and the default 1024.  I added the
> accessors.  I've updated the fate tests.  The changes are file sizes and
> position in files, both of which agree with the changes I made.  I also
> caught a typo in a comment.
> 
> For this third round I found that the avi muxer adds some padding, so I
> let the new option control it.  This change resulted in the many changes
> to fate results because it now add 1024 bytes of padding rather than
> 1016.  To silence this I could change the default to silence these
> changes.  The 1024 bytes is a somewhat arbitrary value anyway.
> 
> A last question.  Should I split up the fate patch and merge it into the
> patches which cause the changes?

patchset applied without changing any defaults

If you still want to change the defaults, that requires testing
with various players and a reason why.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140124/f9cab44d/attachment.asc>


More information about the ffmpeg-devel mailing list