[FFmpeg-devel] [PATCHv5 3/3] vorbis: extract metadata from the middle of a stream

[wm4]

On Sun, 19 Jan 2014 01:33:25 +0000 (UTC)
Ben Boeckel <mathstuf at gmail.com> wrote:


> > i hope midstream reallocation of metadata wont cause any problems
> 
> I haven't noticed anything with mpv so far. Looking through usages of
> AVStream->metadata (detected by deprecating the field then looking at
> the warnings) to see if there's anything to worry about, there's no
> place where AVStream->metadata is stored other than a local variable
> (usually for switching between AVFormatContext->metadata and
> AVStream->metadata).

Some applications might expect that the AVDictionary is never freed
before closing the context, or something like that. But it's probably
not an issue.

Also, maybe post your next iteration of patches under a new thread.
This one is already 4 months old.