[FFmpeg-devel] [PATCH] VQA-highcolor (15 bit rgb555) decoder by Adam Iglewski

Carl Eugen Hoyos cehoyos at ag.or.at
Mon Jan 13 11:51:42 CET 2014


 <u-owvm <at> aetey.se> writes:

> +    if(!AV_RL16(&s->avctx->extradata[14]))
> +        avctx->pix_fmt = PIX_FMT_RGB555;

(Is this correct on big-endian?)

> +    else
> +        avctx->pix_fmt = PIX_FMT_PAL8;

1. In most files, there is a space between "if" and "(" and 
since that's currently true for this file, please do so 
as well. (Same below.)

2. It was argued in the past that
if (condition) {
    do1;
} else {
    do2;
}
costs only one line but makes possible future patches 
much easier to read.

> -

Try to remove such changes, they only make the diff 
bigger.

> +            if(!type) {
> +                    blocks_done = code;

Indentation is four spaces.

Sorry for the style-only comment, Carl Eugen



More information about the ffmpeg-devel mailing list