[FFmpeg-devel] [PATCH 1/4] lavf: add write_uncoded_frame() API.

[Michael Niedermayer]

On Sat, Jan 04, 2014 at 11:20:26AM +0100, Nicolas George wrote:
> Le quintidi 15 nivôse, an CCXXII, Ramiro Polla a écrit :
> > Why not av_write_uncoded_frame and av_interleaved_write_uncoded_frame
> > instead of using this flag?
> 
> Again, I have no strong opinion about the issue.
> 
> One thing though: I believe the shorter name should be for the "normal" API.
> 
> In that regard, av_write_frame() / av_interleaved_write_frame() is bad: the
> normal API is av_interleaved_write_frame(), and you should only use
> av_write_frame() if you really know what you are doing.
> 
> I do not want to copy that mistake.

i see your argument but then IMO having the naming inconsistent
could make it hard to understand and

av_interleaved_write_frame
av_interleaved_write_uncoded_frame
av_write_frame
av_write_uncoded_frame

looks nicer to me than

av_interleaved_write_frame
av_write_uncoded_frame
av_write_frame
av_noninterleaved_write_uncoded_frame

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140104/69d5b2a9/attachment.asc>