[FFmpeg-devel] [PATCH 3/5 v2] libx265: Support SAR

[Steve Borho]

On Fri, Feb 21, 2014 at 1:42 PM, Derek Buitenhuis <
derek.buitenhuis at gmail.com> wrote:

> On 2/21/2014 7:36 PM, Michael Niedermayer wrote:
> > encoding a file with 0,0 aspect and one with 1,0 differ
> > and one with 5/7 aspect and 1/0 aspect differ only in 2 bytes
>
> See below.
>
> > not setting bEnableAspectRatioIdc produces a smaller file
>
> Of *course* not setting bEnableAspectRatioIdc makes a smaller file. That
> tells
> x265 to not enable writing the aspect ratio in the VUI. This is entirely
> expected
>
> > so i suspect there are no checks in x265 or the checks dont work
>
> They're there, but I guess they don't work. I've CC'd in Steve for this.
>

Our checks are incomplete; it only errors if they are negative.  I'll fix
the checks to not allow zeros.  I assume a zero should not be allowed in
the numerator or denominator

--
Steve Borho