[FFmpeg-devel] [PATCH 1/2] avcodec: support setting the chroma?intra matrix

[Michael Niedermayer]

On Mon, Feb 10, 2014 at 07:56:34PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 10, 2014 at 06:44:54PM +0000, Carl Eugen Hoyos wrote:
> > Michael Niedermayer <michaelni <at> gmx.at> writes:
> > 
> > > +     * custom intra quantization matrix
> > > +     * Code outside libavcodec should access this 
> > > field using av_codec_g/set_chroma_intra_matrix()
> > > +     * - encoding: Set by user, can be NULL.
> > 
> > > +     * - decoding: Set by libavcodec.
> > 
> > Is it set by libavcodec?
> 
> locally fixed
> 
> 
> > 
> > > +        if (s->avctx->chroma_intra_matrix)
> > > +            chroma_matrix = s->avctx->chroma_intra_matrix;
> > >          if (s->avctx->intra_matrix) {
> > > -            chroma_matrix =
> > >              luma_matrix = s->avctx->intra_matrix;
> > 
> > Sorry if I misunderstand:
> > So far, if the user had set intra_matrix, it was used 
> > for both luma and chroma (correct?): Does the patch 
> > change this behaviour?
> 
> locally fixed
> 

both patches applied

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140218/3d1c9afb/attachment.asc>