[FFmpeg-devel] [PATCH v2] Add libx265 encoder

[Amnon Israely]

ok looks like old name is back

inputBitDepth

*api: change name back to inputBitDepth, to avoid breaking ffmpeg*

*https://bitbucket.org/multicoreware/x265/commits/ce96cdb390fe26aee6effa731e51303c1d9056b0
<https://bitbucket.org/multicoreware/x265/commits/ce96cdb390fe26aee6effa731e51303c1d9056b0>*


2014-02-16 10:18 GMT+02:00 Amnon Israely <amnonbb at gmail.com>:

> After this commit in x265
>
> https://bitbucket.org/multicoreware/x265/commits/b1f5fd61883a0f375bbb5012fc41a5661c0b9389?at=default
>
> -    /* This is the encoder internal bit depth */
> -    pic->bitDepth = param->inputBitDepth;
> +    pic->bitDepth = param->internalBitDepth;
>      pic->colorSpace = param->internalCsp;
>  }
>
> ffmpeg does not compile
>
> libavcodec/libx265.c:105:18: error: no member named 'inputBitDepth' in
> 'struct x265_param'
>     ctx->params->inputBitDepth   =
> av_pix_fmt_desc_get(avctx->pix_fmt)->comp[0].depth_minus1 + 1;
>
>
>
>
> 2014-02-11 23:36 GMT+02:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
>
> On 2/11/2014 9:29 PM, James Almer wrote:
>> > Missing general.texi changes for HEVC encoding.
>>
>> Added locally.
>>
>> >> +- libx265 encoder
>> >
>> > nit: wrapper?
>>
>> It's already implied by the 'lib' in libx265.
>>
>> >> +    x265_param_default(ctx->params);
>> >> +    if (x265_param_default_preset(ctx->params, ctx->preset,
>> ctx->tune) < 0)
>> >> +        av_log(avctx, AV_LOG_WARNING, "Invalid preset or tune.\n");
>> >
>> > Shouldn't this return AVERROR(EINVAL) instead? We're currently doing
>> that with libx264.
>> > Doesn't seem like a good idea proceeding with what could potentially be
>> a big encoding
>> > after the user typoed the preset/tune he wanted.
>>
>> It's not strictly a fatal error IMO, but I'll go with whatever
>> the popular opinion is.
>>
>> >> +static const AVOption options[] = {
>> >> +    { "preset",      "set the x265 preset",
>>                              OFFSET(preset),    AV_OPT_TYPE_STRING, { 0 },
>> 0, 0, VE },
>> >> +    { "tune",        "set the x265 tune parameter",
>>                              OFFSET(tune),      AV_OPT_TYPE_STRING, { 0 },
>> 0, 0, VE },
>> >> +    { "x265-params", "set the x265 configuration using a :-separated
>> list of key=value parameters", OFFSET(x265_opts), AV_OPT_TYPE_STRING, { 0
>> }, 0, 0, VE },
>> >> +    { NULL },
>> >> +};
>> >
>> > nit: vertical alignment.
>>
>> Fixed locally.
>>
>> - Derek
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>
>