[FFmpeg-devel] [PATCH 01/10] dcadsp: remove scaling in LFE FIR

[Michael Niedermayer]

On Sat, Feb 15, 2014 at 08:25:28AM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2014-02-14 23:19 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> > I suggest instead of replacing the numeric values to instead use
> > a macro like
> > DECLARE_ALIGNED(16, static const float, lfe_fir_64)[] =
> > {
> >     LFE_FIR_SCALE(2.658434386830777e-4), LFE_FIR_SCALE(9.029330685734748e-3),
> >     ...
> >
> > to do the scaling
> > this way different scales can be used without the need to replace
> > the whole table in the source
> 
> Indeed I'm not sure how much this was future-proof. I'm still not, in
> particular if dtshd support requires a different handling.
> 

> Another point about this patch is that it requires changes in the arm
> code (won't even compile).

you can test arm code with qemu if you dont have arm hardware

if you dont want to build your own cross compiler,
useable cross compilers are available at http://www.emdebian.org/
(they work on debian and ubuntu at least last i checked)

also if someone sets up a cross compiler and qemu to test ffmpeg,
please document it on our trac wiki, so the next then has a easy step
by step guide to follow

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140215/9f7ddc06/attachment.asc>