[FFmpeg-devel] [PATCH 1/7] lavc/flacenc: add sse4 version of the lpc encoder

[James Darnley]

On 2014-02-15 00:48, Michael Niedermayer wrote:
> On Fri, Feb 14, 2014 at 12:40:06PM +0100, James Darnley wrote:
>> From 1.8 to 2.4 times faster.  Runtime is reduced by 2 to 39%.  The
>> speed-up generally increases with compression_level.
>>
>> This lpc encoder is not used with levels < 3 so it provides no speed-up
>> in these cases.
>> ---
>>  LICENSE                         |    1 +
>>  libavcodec/x86/Makefile         |    3 ++
>>  libavcodec/x86/flac_dsp_gpl.asm |   76 +++++++++++++++++++++++++++++++++++++++
>>  libavcodec/x86/flacdsp_init.c   |    4 ++
>>  4 files changed, 84 insertions(+), 0 deletions(-)
>>  create mode 100644 libavcodec/x86/flac_dsp_gpl.asm
> 
> fails to build
> 
> `ff_flac_enc_lpc_16_sse4' referenced in section `.text.unlikely' of libavcodec/libavcodec.a(flacdsp_init.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(flac_dsp_gpl.o)
> collect2: ld returned 1 exit status
> make: *** [libavformat/seek-test] Error 1
> make: *** Waiting for unfinished jobs....
> `ff_flac_enc_lpc_16_sse4' referenced in section `.text.unlikely' of libavcodec/libavcodec.a(flacdsp_init.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(flac_dsp_gpl.o)
> collect2: ld returned 1 exit status
> make: *** [libavfilter/filtfmts-test] Error 1
> `ff_flac_enc_lpc_16_sse4' referenced in section `.text.unlikely' of libavcodec/libavcodec.a(flacdsp_init.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(flac_dsp_gpl.o)
> collect2: ld returned 1 exit status
> make: *** [ffmpeg_g] Error 1
> `ff_flac_enc_lpc_16_sse4' referenced in section `.text.unlikely' of libavcodec/libavcodec.a(flacdsp_init.o): defined in discarded section `.note.GNU-stack' of libavcodec/libavcodec.a(flac_dsp_gpl.o)
> collect2: ld returned 1 exit status
> make: *** [ffprobe_g] Error 1
> 
> [...]

Damn.  Does x86inc.asm not set the right section be default?  Try adding
SECTION_TEXT as the first line in flac_dsp_gpl.asm.  I see most other
files have the line after various constants but I thought it would be
default.

I'll send an an updated patch in a few minutes.  Then I'm going to sleep.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 683 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140215/f1fc479f/attachment.asc>