[FFmpeg-devel] Fix libssh static linkage on Windows

Michael Niedermayer michaelni at gmx.at
Tue Feb 11 01:46:19 CET 2014


On Mon, Feb 10, 2014 at 10:32:30PM +0100, Lukasz M wrote:
> On 10 February 2014 22:22, Derek Buitenhuis <derek.buitenhuis at gmail.com>wrote:
> 
> > On 2/10/2014 9:16 PM, Lukasz M wrote:
> > > I asked on their mailing list
> > > http://www.libssh.org/archive/libssh/2014-02/0000057.html
> > >
> > > The person who answerred told he's not a windows developer, but suggested
> > > to set this on compiler commandline, which is the same as my first
> > > thought was.
> > >
> > > Maybe adding a comment with a hint would be more safe than that define.
> >
> > Hi.
> >
> > I would just like to note we already do something similar for x264:
> >
> >
> > http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/libx264.c;h=60076301a67af1e707ff959201d220ecdf770e94;hb=HEAD#l30
> >
> > I think it's more correct to have it in the header, like Matt
> > already does. I say this as the person who put in a lot of work
> > for MSVC and Windows support in general.
> >
> 
> Personally I'm not agains merging this. Maybe with some ifdef for windows
> builds.
> This is more platform support issue than sftp support in ffmpeg, so I trust
> people who knows windows better than me.

merged

thanks



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140211/0ef7ee0c/attachment.asc>


More information about the ffmpeg-devel mailing list