[FFmpeg-devel] [FFmpeg-cvslog] Fix compilation with --disable-everything --enable-encoder=flac.

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Feb 8 17:03:56 CET 2014


James Darnley <james.darnley <at> gmail.com> writes:

> On 2014-02-08 12:23, Clément Bœsch wrote:

> >> -    if (ARCH_X86)
> >> +    if (ARCH_X86 && CONFIG_FLAC_DECODER)
> >>          ff_flacdsp_init_x86(c, fmt, bps);
> >>  }
> > 
> > 
> > Why not ARM? It's in the same situation AFAICT.

Because there is no --enable-random arm fate target 
and because I cannot test.

> > Also, why not instead add
> > the flacdsp_init*.o to the
> > libavcodec/{arm,x86}/Makefile:OBJS-$(CONFIG_FLAC_ENCODER)?

I thought the solution I took saves one symbol.

[...]

> Alternatively I could fix it with some #if conditions

Please make it if() conditions if applicable.

Carl Eugen



More information about the ffmpeg-devel mailing list