[FFmpeg-devel] [PATCH 2/2] lavd/sdl: reset context variables after destroy

Michael Niedermayer michaelni at gmx.at
Sat Feb 8 03:20:08 CET 2014


On Sat, Feb 08, 2014 at 02:12:43AM +0100, Lukasz Marek wrote:
> On 07.02.2014 17:08, Nicolas George wrote:
> >Le nonidi 19 pluviôse, an CCXXII, Lukasz M a écrit :
> >>Yes, I investigated.
> >>write_trailer is called for the first time in write_packet when quit flag
> >>is set.
> >>Second write_trailer comes from ffmpeg.c
> >>
> >>I was thinking about removing that call from write_packet too, seems
> >>redundant.
> >
> >I see, thanks for explaining. I do not know whether this is redundant (there
> >is unfortunately no common cleanup code for muxers, that would be called
> >even when muxing fails), but it is clearly wanted and not a bug, and this
> >patch is therefore necessary and correct.
> 
> That is possible. I remember the issue wasn't present when Stefano
> commited it, but started to occur recently. Maybe someone added some
> clean up code in the meantime.
> 
> >Maybe copy-paste this message to the commit message.
> 
> OK, attached.

applied both patches

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140208/08d4df03/attachment.asc>


More information about the ffmpeg-devel mailing list