[FFmpeg-devel] [PATCH 13/15] vp9/x86: make filter_44_h work on 32-bit.

[Ronald S. Bultje]

Hi,

On Sat, Dec 27, 2014 at 1:30 PM, Clément Bœsch <u at pkh.me> wrote:

> On Sat, Dec 27, 2014 at 11:02:48AM -0500, Ronald S. Bultje wrote:
> > ---
> >  libavcodec/x86/vp9dsp_init.c |   4 +-
> >  libavcodec/x86/vp9lpf.asm    | 140
> ++++++++++++++++++++++++-------------------
> >  2 files changed, 78 insertions(+), 66 deletions(-)
> >
> > diff --git a/libavcodec/x86/vp9dsp_init.c b/libavcodec/x86/vp9dsp_init.c
> > index 40e51a0..c5decfa 100644
> > --- a/libavcodec/x86/vp9dsp_init.c
> > +++ b/libavcodec/x86/vp9dsp_init.c
> > @@ -353,9 +353,7 @@ av_cold void ff_vp9dsp_init_x86(VP9DSPContext *dsp)
> >          dsp->loop_filter_16[0] = ff_vp9_loop_filter_h_16_16_##opt; \
> >      } \
> >      dsp->loop_filter_16[1] = ff_vp9_loop_filter_v_16_16_##opt; \
> > -    if (ARCH_X86_64) { \
> > -        dsp->loop_filter_mix2[0][0][0] =
> ff_vp9_loop_filter_h_44_16_##opt; \
> > -    } \
> > +    dsp->loop_filter_mix2[0][0][0] = ff_vp9_loop_filter_h_44_16_##opt; \
> >      dsp->loop_filter_mix2[0][0][1] = ff_vp9_loop_filter_v_44_16_##opt; \
> >      if (ARCH_X86_64) { \
> >          dsp->loop_filter_mix2[0][1][0] =
> ff_vp9_loop_filter_h_48_16_##opt; \
> > diff --git a/libavcodec/x86/vp9lpf.asm b/libavcodec/x86/vp9lpf.asm
> > index 04051fe..c111f48 100644
> > --- a/libavcodec/x86/vp9lpf.asm
> > +++ b/libavcodec/x86/vp9lpf.asm
> > @@ -287,38 +287,6 @@ SECTION .text
> >      SWAP %12, %14
> >  %endmacro
> >
> > -; transpose 16 half lines (high part) to 8 full centered lines
>
> So this comment doesn't apply anymore?


I replaced it with the more generic "; 8x16 transpose" comment. I can
unreplace it with the original comment if you prefer.

Ronald