[FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

Michael Niedermayer michaelni at gmx.at
Tue Dec 23 13:58:45 CET 2014

On Thu, Dec 18, 2014 at 12:12:14AM +0100, Stefano Sabatini wrote:
> > +static void mul_thrmat_c(FSPPContext *p, int q)
> > +{
> > +    int a;
> > +    for (a = 0; a < 64; a++)
> > +        ((short*)p->threshold_mtx)[a] = q * ((short*)p->threshold_mtx_noq)[a];//ints faster in C
> short -> int8_t (probably more readable)

whatever effect it may have on readability it is wrong and not working

Please take more time for the reviews, i think its importat that the
suggestions you make do not add bugs. It can take alot of time to find
such bugs later

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141223/977df15f/attachment.asc>

More information about the ffmpeg-devel mailing list