[FFmpeg-devel] ffmpeg nvenc

Wed Dec 17 10:34:56 CET 2014

Repost

-----Original Message-----
From: Agatha Hu 
Sent: 2014年12月17日 15:49
To: 'Philip Langdale'; 'ffmpeg-devel at ffmpeg.org'
Cc: Abhijit Patait; Eric Young; Jaime Ieong; Andrew Fear; Stephen Warren; Andy Ritger
Subject: RE: ffmpeg nvenc

Hi Phil,

We've almost finished the license part in our patch and plan to commit to ffmpeg community, but we found ffmpeg add Timo's nvenc patch days ago, so our patch is incompatible with the TOT version.
Should we (1)Add libnvenc on TOT branch but without changing Timo's work or (2)Change nvenc on TOT branch like an incremental patch on Timo's work. In fact I would prefer (1), as it requires less work.

Agatha Hu

-----Original Message-----
From: Philip Langdale [mailto:philipl at overt.org]
Sent: 2014年12月1日 15:04
To: Agatha Hu
Cc: Abhijit Patait; Eric Young; Jaime Ieong; Andrew Fear; Stephen Warren
Subject: Re: ffmpeg nvenc

Sure thing. Thanks,

--phil

On Mon, 1 Dec 2014 02:59:42 +0000
Agatha Hu <ahu at nvidia.com> wrote:

> Hi Phil, we're discussing internally, I'll let you know when we finish 
> the legal issue.
> 
> -----Original Message-----
> From: Philip Langdale [mailto:philipl at overt.org]
> Sent: 2014年11月29日 2:39
> To: Abhijit Patait
> Cc: Agatha Hu; Eric Young; Jaime Ieong; Stephen Warren; Andrew Fear
> Subject: Re: ffmpeg nvenc
> 
> And FYI, someone has posted an independent implementation of nvenc 
> support to the ffmpeg-devel mailing list.
> 
> http://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg06257.html
> 
> It's simpler than your version, but I think there's a lot of virtue in 
> your attempt at mapping the x264 configuration options. You guys 
> should get engaged in the conversation.
> 
> --phil
> 
> On Thu, 27 Nov 2014 06:15:21 +0000
> Abhijit Patait <apatait at nvidia.com> wrote:
> 
> > +Andrew
> > 
> > -----Original Message-----
> > From: Philip Langdale [mailto:philipl at overt.org]
> > Sent: Wednesday, November 26, 2014 10:57 AM
> > To: Agatha Hu
> > Cc: Eric Young; Jaime Ieong; Abhijit Patait; Stephane Warnon
> > Subject: Re: ffmpeg nvenc
> > 
> > On Tue, 25 Nov 2014 05:28:36 +0000
> > Agatha Hu <ahu at nvidia.com> wrote:
> > 
> > > +more people
> > > I guess at first we plan to release it as a patch to ffmpeg forum? 
> > > No, the code was first developed by Jaime, I don't think Stephane 
> > > knew the detail. And there's no tracking internally because of 
> > > some license issue. As ffmpeg is open-sourced gnu project, but 
> > > nvenc is not, it only provides header and dll.
> > 
> > So, to get this accepted, all the files in the ffmpeg patch need to 
> > be licensed as LGPL 2.1 (or later). nvEncoder.h and cuda.h are 
> > separate, but due to their licensing, the nvenc feature would need 
> > to be part of the 'nonfree' set of ffmpeg functionality (which I see 
> > is already in the patch).
> > 
> > --phil
> > 
> > > Agatha Hu
> > > 
> > > -----Original Message-----
> > > From: Philip Langdale [mailto:philipl at overt.org]
> > > Sent: 2014年11月25日 13:14
> > > To: Agatha Hu
> > > Subject: Re: ffmpeg nvenc
> > > 
> > > Hi Agatha,
> > > 
> > > First off, it's great that you've been working on the nvenc-ffmpeg 
> > > integration - I've already found it to be very effective! And so 
> > > I'm very keen to see it get merged into upstream ffmpeg - but 
> > > without clear licensing, the current patch won't get accepted.
> > > Stephen Warren at nvidia did a lot of the work on the VDPAU 
> > > patches for ffmpeg, so he's got experience working with them and 
> > > getting code merged. Have you talked to him about this? If not, 
> > > I'd highly recommend it.
> > > 
> > > As I said, I've got a handful of improvements I'd like to feed 
> > > back to you, and github is fine for this, but I don't know what 
> > > your plans and whether you're already tackling these things. I've 
> > > got fixes for setting the right aspect ratio (although this 
> > > involved some black magic) and correctly handling b-frames.
> > > 
> > > Thanks,
> > > 
> > > --phil
> > > 
> > > On Tue, 25 Nov 2014 10:22:58 +0800 agatha Hu <agatha621 at gmail.com>
> > > wrote:
> > > 
> > > > Hi Phillip, yes I'm working in NVIDIA, can you contact me with 
> > > > ahu at nvidia.com? Thanks
> > > > 
> > > > 2014-11-25 0:21 GMT+08:00 Philip Langdale <philipl at overt.org>:
> > > > 
> > > > > Hi,
> > > > >
> > > > > I saw that you published a git repo with basic nvenc suport on 
> > > > > github, and I've been playing with it over the weekend, and 
> > > > > making some improvements like b-frame support, but the 
> > > > > licensing of the code is very unclear - some files have an 
> > > > > NVIDIA copyright on them and libnvenc.c has no licence on it 
> > > > > at all. In this state, it will never be possible to merge it 
> > > > > into upstream ffmpeg. The NVIDIA copyrighted files are not 
> > > > > ones that I've seen anywhere else, so they don't look like 
> > > > > public sample code. Do you work for NVIDIA?
> > > > >
> > > > > Anyway, I'd like to try and get the nvenc support merged (and 
> > > > > I have experience writing a new codec for ffmpeg and getting 
> > > > > that merged) but licence clarification is the first key step.
> > > > >
> > > > > Thanks!
> > > > >
> > > > > --phil
> > > > >
> > > 
> > > 
> > > 
> > > 
> > > --phil
> > 
> > 
> > 
> > 
> > --phil
> > 
> > --------------------------------------------------------------------
> > --
> > ------------- This email message is for the sole use of the intended
> > recipient(s) and may contain confidential information.
> > Any unauthorized review, use, disclosure or distribution is 
> > prohibited. If you are not the intended recipient, please contact 
> > the sender by reply email and destroy all copies of the original 
> > message.
> > --------------------------------------------------------------------
> > --
> > -------------