[FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

[Carl Eugen Hoyos]

arwa arif <arwaarif1994 <at> gmail.com> writes:

> + * it under the terms of the GNU General Public License

The configure part is missing that makes sure the 
filter is only compiled when --enable-gpl was used.

> +DECLARE_ALIGNED(32, static const uint8_t, dither)[8][8] = {
> +    {  0,  48,  12,  60,   3,  51,  15,  63, },

This does not belong in a header, only the declaration 
should be there, the actual data should be in a c file.

Same for column_fidct_c(), row_idct_c() and row_fdct_c().

> +#if HAVE_MMX_INLINE

I believe you can remove this line twice and just do (below):
if (HAVE_MMX_INLINE && cpu_flags & AV_CPU_FLAG_MMX) {

FFmpeg absolutely relies on dead code elimination.

Carl Eugen