[FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

[Carl Eugen Hoyos]

arwa arif <arwaarif1994 <at> gmail.com> writes:

> I have tried to port fspp. Not sure, if it is 
> correct or not.

Did you compare the output of -vf fspp and -vf mp=fspp?

> +av_cold void ff_fspp_init_x86(FSPPContext *s)
> +{
> +#if HAVE_MMX_INLINE
> +    int cpu_flags = av_get_cpu_flags();
> +
> +    if (cpu_flags & AV_CPU_FLAG_MMX) {
> +
> +#define store_slice_s store_slice_mmx
> +#define store_slice2_s store_slice2_mmx
> +#define mul_thrmat_s mul_thrmat_mmx
> +#define column_fidct_s column_fidct_mmx
> +#define row_idct_s row_idct_mmx
> +#define row_fdct_s row_fdct_mmx

This does not look correct:
You have to add function pointers to FSPPContext 
and these have to be initialized in init() and 
overwritten in ff_fspp_init_x86() if mmx is 
available.
See commits a2c547ff and 852f74bd by Clement 
for reference:
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=a2c547ff
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=852f74bd

Carl Eugen