[FFmpeg-devel] [PATCH 1/2] lavd/avdevice: replace av_ with ff_ for caps option table
lukasz.m.luki2 at gmail.com
Sat Dec 13 21:00:07 CET 2014
On 13.12.2014 20:54, Lukasz Marek wrote:
> On 13.12.2014 20:48, Reimar Döffinger wrote:
>> On 13.12.2014, at 20:42, James Almer <jamrial at gmail.com> wrote:
>>> On 13/12/14 4:27 PM, Lukasz Marek wrote:
>>>> This symbol is required for query capabilities callbacks.
>>>> This symbol is only required by libavdevice and should not be exported.
>>> This need a deprecation and an FF_API scheduled removal. We can't
>>> remove the symbol
>>> without a major bump.
>> Well, there is a comment saying it should not be used (which raises
>> the question why it was placed in that header though).
>> If a search can't find anyone using it, it might not be _completely_
>> unreasonable to cheat and remove it without a major bump.
>> But I have no strong opinion either way.
> Yes. There is a comment about that it is internal. So I don't think it
> is serious to rename it. We already renamed symbols, but probably in not
> exported headers though.
> Unless user created own device and implemented capabilities query, it is
> not used yet. It is not used in ffmpeg project. I'm about to push first
> implementations so I wanted to fix it before, as spotted.
Now I have second thought, removing/renaming this symbol will not allow
to do that. (to implement device outside ffmpeg project and use caps
querying). It is quite long since discussion about this API and I forget
context of some things.
So this should stay as it is, just the comment have to be clarified it
can be used just for this purpose, not to mangle with values "manually"
Sorry for double posting.
More information about the ffmpeg-devel