[FFmpeg-devel] [PATCH 3/5] lavu/dict: remove weird intptr_t cast

[wm4]

On Sat, 13 Dec 2014 13:55:44 +0100
Nicolas George <george at nsup.org> wrote:

> > > I can't come up with a reason why this would be needed.
> 
> Reading the commit message where this was introduced would be a good start:
> 
> # commit 8aed90958d8bbf4a0652fdc56b9655ad9962fa50
> # Author: Michael Niedermayer <michaelni at gmx.at>
> # Date:   2011-10-17 22:56:13 +0200
> # 
> #     dict: fix assignment discards qualifiers from pointer target type warnings.
> #     
> #     Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

Sorry to disrupt your smartass moment, but I've already run blame when
I first looked at it. The commit message explains nothing about the
intptr_t.

> 
> Le tridi 23 frimaire, an CCXXIII, Michael Niedermayer a écrit :
> > if people prefer this, i can apply it, it might cause an additional
> > warning with some compilers though
> 
> For what it's worth, I prefer the code building with fewer warnings.

A simple cast already prevents the warning.