[FFmpeg-devel] [PATCH 2/2] Adding closed caption decoder

Anshul anshul.ffmpeg at gmail.com
Wed Dec 3 19:08:42 CET 2014

On 12/03/2014 10:19 PM, Clément Bœsch wrote:
> unless i'm mistaken, i think you just want:
>     return av_popcount(val & 0x7f) & 1;
Thanks I was searching for this, even I asked for same on Irc.

Nicolas: The changes from your pair of patch,
1) I removed c708 part (whole) since both are same, 708 just have some
extra feature then 608.
    In your first patch it was just registering c708, and I have not
used that patch.

2) you used i as the index of subcc, but I have used stream_idx
your code was lavfi->sink_stream_subcc_map[i] = !!use_subcc; 
I changed it to
 lavfi->sink_stream_subcc_map[stream_idx] = !!use_subcc; 

There were one more changes but that was  to get your patch in mainstream
like av_malloc_array instead av_malloc.

I have considered all your comments, but it would be better to check again.

I have also tested with valgrind, its report is good.

I have attached both patch here.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-allow-to-extract-subcc.patch
Type: text/x-patch
Size: 8013 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141203/4961bd5b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Adding-Closed-caption-Decoder.patch
Type: text/x-patch
Size: 11538 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141203/4961bd5b/attachment-0001.bin>

More information about the ffmpeg-devel mailing list