[FFmpeg-devel] [PATCH] pngdsp x86: use scalar loop for unaligned dest buffers.

Benoit Fouet benoit.fouet at free.fr
Tue Dec 2 14:15:52 CET 2014


----- Mail original -----
> Hi,
> 2014-12-02 13:51 GMT+01:00 Benoit Fouet <benoit.fouet at free.fr>:
> > Signed-off-by: Christophe Gisquet <christophe.gisquet at gmail.com>
> > Signed-off-by: Benoit Fouet <benoit.fouet at gmail.com>
> While I suggested that the change be written like this, I didn't
> think
> long about that specific code, and overall, I really don't think this
> change is what should be applied. Though you probably tested that it
> allows correct decoding.

It indeed allows decoding without crashing, which is IMHO a minimum.

> I'm for writing a SIMD unaligned loop, the question being whether it
> should be the only path. SSE4 version of add_hfyu_left_pred for
> instance has 3 paths for various alignments.

I understood that, though, as stated, I'm not able to do that, this is why I sent this one instead, just to have something working in the tree.
I can add a TODO or something like that instead, would that be OK?


More information about the ffmpeg-devel mailing list